Change in flashrom[master]: [v4, 3/6] ENE EDI - add dummy read to ensure proper detection of ENE c...
Mike Banon has posted comments on this change. ( https://review.coreboot.org/23260 )
Change subject: [v4,3/6] ENE EDI - add dummy read to ensure proper detection of ENE chips ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/23260/1/edi.c File edi.c:
https://review.coreboot.org/#/c/23260/1/edi.c@500 PS1, Line 500: edi_detect(flash);
`edi_detect` sounds a little like it would already probe for it... […]
Yes, edi_detect is a function that includes probing - but this function would never be called if KB9012 has not been explicitly selected by the user. One of the following patches moves KB9012 into the "hidden chips" domain - these chips would still shown as supported by flashrom as well as other chips, but a hidden chip (KB9012 in this case) isn't probed for by flashrom unless the user chooses it with -c option
-
Mike Banon (Code Review)