Attention is currently required from: Felix Singer, Nico Huber, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67393 )
Change subject: tree/: Move programmer_delay() out of programmer state machine
......................................................................
Patch Set 4:
(1 comment)
File serprog.c:
https://review.coreboot.org/c/flashrom/+/67393/comment/bac64ef1_bad7fa69
PS4, Line 451: };
Actually I looked at this again, and yes this probably needs delay too. […]
Leaving as unresolved, thanks for spotting that Nico. Fixed locally, will push a rebased update once CB:66373 lands.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67393
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id059abb58b31a066a408009073912da2b224d40c
Gerrit-Change-Number: 67393
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov
chat@joursoir.net
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 07 Oct 2022 10:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment