Attention is currently required from: Nico Huber, Thomas Heijligen, Daniel Verkamp.
Hello Felix Singer, build bot (Jenkins), Daniel Verkamp, Thomas Heijligen, Edward O'Callaghan, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/67845
to look at the new patch set (#2).
Change subject: pcidev: Always fetch ident info ......................................................................
pcidev: Always fetch ident info
As discovered earlier[1], the `vendor_id` and `device_id` fields are not always automatically set. However, we use these fields throughout flash- rom. To not lose track when we actually fetched them, let's always call pci_fill_info(PCI_FILL_IDENT) before returning a `pci_dev` handle.
[1] Commit ca2e3bce0 (pcidev.c: populate IDs with pci_fill_info())
Backported to older versions where pcidev handling was much more scattered.
Signed-off-by: Nico Huber nico.h@gmx.de Change-Id: Iae2511178bec44343cbe902722fdca9eda036059 Ticket: https://ticket.coreboot.org/issues/367 Reviewed-on: https://review.coreboot.org/c/flashrom/+/64573 --- M board_enable.c M internal.c 2 files changed, 39 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/67845/2