Change in flashrom[master]: edi: Print debug info like others while probing for ENE chips
Nico Huber has posted comments on this change. ( https://review.coreboot.org/23261 )
Change subject: edi: Print debug info like others while probing for ENE chips ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/23261/5/edi.c File edi.c:
https://review.coreboot.org/#/c/23261/5/edi.c@164 PS5, Line 164: if (chip->hwversion == hwversion && chip->ediid == ediid) {
Originally it was msg_cdbg but I changed it to msg_cdbg2 after Nico's request.
That was about the `else` path.
Do you think its a good idea to change it back to msg_cdbg ?
It should match what is common in flashrom. Looking at compare_id() in spi25.c, it just always prints the read ids at msg_cdbg.
Also, right now if hwversion and/or ediid do not match these values , the exit code is 0 - while, if they match, the exit code is 1. If we replace it with a single msg line, what exit code should it be? "return 1" for both cases?
The whole purpose of this function is to return 1 if and only if the ids match. The messages are merely cosmetic.
-
Nico Huber (Code Review)