Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83795?usp=email )
Change subject: flashchip: add GD25LB512ME ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: It seems Jenkins didn't run for some reasons, but this happens sometimes. I have one comment, and when you fix it and upload new patchset, this should trigger re-run of Jenkins. Hopefully will be all good.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83795/comment/959f87cc_6179f4f4?usp... : PS1, Line 7074: GIGADEVICE_GD25LR512ME You need to add a comment in `include/flashchips.h`, on the line which defines this model id, a comment like:
Same as GD25LB512ME
When you look into flashchips.h, you will see there are lots of examples of such comments.
-
Anastasia Klimchuk (Code Review)