Change in flashrom[master]: default programmer: use programmer name instead of enum for default p...

[Nico Huber (Code Review)]

Attention is currently required from: Thomas Heijligen.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55123 )

Change subject: default programmer: use programmer name instead of enum for default programmer
......................................................................

Patch Set 5:

(3 comments)

File cli_classic.c:

https://review.coreboot.org/c/flashrom/+/55123/comment/e49e56a8_ee17cafb 
PS5, Line 546: 		#ifdef CONFIG_DEFAULT_PROGRAMMER_NAME
             : 			#define PASTER(x) &programmer_ ## x
             : 			#define EVALUATOR(x)  PASTER(x)
             : 			static const struct programmer_entry *default_programmer = EVALUATOR(CONFIG_DEFAULT_PROGRAMMER_NAME);
             : 		#else
             : 			static const struct programmer_entry *default_programmer = NULL;
             : 		#endif
             : 
This should be much easier to handle outside of C (i.e. Makefile / meson.build). Just prepend "&programmer_" when passing it to `-D`?

https://review.coreboot.org/c/flashrom/+/55123/comment/172c5a90_1d3a658e 
PS5, Line 554: 		#ifndef CONFIG_DEFAULT_PROGRAMMER_ARGS
             : 			#define CONFIG_DEFAULT_PROGRAMMER_ARGS ""
             : 		#endif
This too should be covered outside C. How did it work before?

File util/manibuilder/README.md:

https://review.coreboot.org/c/flashrom/+/55123/comment/13643d6d_04a76007 
PS5, Line 66:     cc -MMD -Os -Wall -Wshadow -Werror -I/usr/include/libusb-1.0  -D'CONFIG_SERPROG=1' -D'CONFIG_PONY_SPI=1' -D'CONFIG_BITBANG_SPI=1' -D'CONFIG_GFXNVIDIA=1' -D'CONFIG_SATASII=1' -D'CONFIG_ATAVIA=1' -D'CONFIG_IT8212=1' -D'CONFIG_FT2232_SPI=1' -D'CONFIG_USBBLASTER_SPI=1' -D'CONFIG_PICKIT2_SPI=1' -D'HAVE_FT232H=1'  -D'CONFIG_DUMMY=1' -D'CONFIG_DRKAISER=1' -D'CONFIG_NICINTEL=1' -D'CONFIG_NICINTEL_SPI=1' -D'CONFIG_NICINTEL_EEPROM=1' -D'CONFIG_OGP_SPI=1' -D'CONFIG_BUSPIRATE_SPI=1' -D'CONFIG_DEDIPROG=1' -D'CONFIG_DEVELOPERBOX_SPI=1' -D'CONFIG_LINUX_MTD=1' -D'CONFIG_LINUX_SPI=1' -D'CONFIG_CH341A_SPI=1' -D'CONFIG_DIGILENT_SPI=1' -D'NEED_PCI=1'  -D'NEED_RAW_ACCESS=1' -D'NEED_LIBUSB0=1' -D'NEED_LIBUSB1=1' -D'HAVE_UTSNAME=1' -D'HAVE_CLOCK_GETTIME=1' -D'FLASHROM_VERSION="p1.0-141-g9cecc7e"' -o libflashrom.o -c libflashrom.c
It's just an example and should be kept as is. The list of programmers
is also not kept up-to-date ;)