Attention is currently required from: Matt DeVillier.
Anastasia Klimchuk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/flashrom/+/85159?usp=email )
Change subject: cli_classic.c: Make -r/-w/-v argument optional ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Matt, thank you so much for your work! I added one comment already, but I will do another round of review later.
Commit Message:
https://review.coreboot.org/c/flashrom/+/85159/comment/553b68b4_b5913e22?usp... : PS1, Line 7: Make -r/-w/-v argument optional It seems they are not fully optional, they are only optional when `-i` parameter is provided? Maybe it's better to say "optional with -i parameter provided", something like that.
However, the critical important place where it should be explained is not the commit message, but the manpage, you need to update doc/classic_cli_manpage.rst to fully explain the usage.
In this case, also very useful would be to give examples (full command line examples) of a valid usages with this feature.