Change in flashrom[master]: meson: Do not compile with -DSTANDALONE

[Richard Hughes (Code Review)]

Richard Hughes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/42230 )

Change subject: meson: Do not compile with -DSTANDALONE
......................................................................

meson: Do not compile with -DSTANDALONE

This enables the -o option which is used to collect logs for debugging.

Change-Id: If6c12c682ba72cd519e30f1f8c96552322ff75e3
Signed-off-by: Richard Hughes 
---
M meson.build
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/42230/1

diff --git a/meson.build b/meson.build
index 5d8e630..4b00339 100644
--- a/meson.build
+++ b/meson.build
@@ -415,7 +415,6 @@
   ],
   c_args : [
     cargs,
-    '-DSTANDALONE',
     '-DCONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID',
     '-DCONFIG_DEFAULT_PROGRAMMER_ARGS=""',
   ],

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42230 )

Change subject: meson: Do not compile with -DSTANDALONE
......................................................................

Patch Set 1: Code-Review+1

Thanks!

Will test on Thursday, I've got a rather busy day ahead...

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42230 )

Change subject: meson: Do not compile with -DSTANDALONE
......................................................................

Patch Set 1: Code-Review+2

I checked, looks like -DSTANDALONE is meant to be used with libpayload only. There isn't an operating system at that point, so maybe we don't even have a filesystem.

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42230 )

Change subject: meson: Do not compile with -DSTANDALONE
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42230 )

Change subject: meson: Do not compile with -DSTANDALONE
......................................................................

Patch Set 2:

Why wait for Jenkins, it doesn't run meson anyway

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/42230 )

Change subject: meson: Do not compile with -DSTANDALONE
......................................................................

meson: Do not compile with -DSTANDALONE

This enables the -o option which is used to collect logs for debugging.

Change-Id: If6c12c682ba72cd519e30f1f8c96552322ff75e3
Signed-off-by: Richard Hughes 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/42230
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Matt DeVillier 
---
M meson.build
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/meson.build b/meson.build
index ef7ac2c..04176f3 100644
--- a/meson.build
+++ b/meson.build
@@ -426,7 +426,6 @@
   ],
   c_args : [
     cargs,
-    '-DSTANDALONE',
     '-DCONFIG_DEFAULT_PROGRAMMER=PROGRAMMER_INVALID',
     '-DCONFIG_DEFAULT_PROGRAMMER_ARGS=""',
   ],