Attention is currently required from: Anastasia Klimchuk.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/76075?usp=email )
Change subject: doc: Add Team page which describes Gerrit groups ......................................................................
Patch Set 3: Code-Review+2
(16 comments)
Patchset:
PS3: Random thoughts and rephrases, feel free to ignore
File doc/about_flashrom/team.rst:
https://review.coreboot.org/c/flashrom/+/76075/comment/af381d7a_cee36e4a : PS3, Line 9: All contributors and users are expected to follow Development guidelines, : Code of Conduct and Friendliness guidelines. We kindly request all contributors and users to adhere to our Development guidelines, Code of Conduct, and Friendliness guidelines.
https://review.coreboot.org/c/flashrom/+/76075/comment/1e39393c_89fda9bc : PS3, Line 12: . :
https://review.coreboot.org/c/flashrom/+/76075/comment/b51580d1_85e6bbe8 : PS3, Line 16: : Members of the group can do full approval of patches (i.e. vote +2). : : In general, members of the group have some area of responsibility in the MAINTAINERS file, : and are automatically added as reviewers to patches when the patch touches this area. : : The responsibilities are the following. : : * React to patches when added as a reviewer. : : * Try to respond to technical questions on the mailing list if the topic is something you know about : and can provide a useful response. : : * Know development guidelines and check the patches you are reviewing align with the guidelines. This group is made up of individuals who hold the authority to fully approve patches, signified by a +2 vote. As a rule, members of this group often shoulder specific responsibilities noted in the MAINTAINERS file and are automatically included as reviewers for patches that touch upon their areas of responsibility.
Here is a list of what's expected from a member of this group:
* Engage with patches when marked as a reviewer.
* If a technical question is within your area of expertise, strive to respond on the mailing list with a useful answer.
* Be familiar with the development guidelines and ensure the patches under your review adhere to these standards.
https://review.coreboot.org/c/flashrom/+/76075/comment/fe3f417d_534381c3 : PS3, Line 34: Members of the group can merge patches. : The responsibilities for the members of the group are described in more details below. Members of this group are authorized to merge patches. Below is a more detailed description of the group members' duties.
https://review.coreboot.org/c/flashrom/+/76075/comment/4f41e920_983aff7e : PS3, Line 37: There is no expectation on how much time you spend on your duties, some non-zero amount of time, : whatever capacity you have. But in general, you stay around on flashrom. : We don't set any stringent demands on how much time you should devote to your duties. Any non-zero amount of time, as per your capacity, is appreciated. However, consistent engagement with flashrom and the community is expected.
https://review.coreboot.org/c/flashrom/+/76075/comment/3446319f_c2fc04af : PS3, Line 40: If you disappear for some time (life happens), especially for a longer time, like several months, : especially without a warning: you implicitly agree that the others will handle the duties and make decisions if needed : (potentially without waiting for you to come back, if the decision is needed quickly). : If circumstances cause you to step away for a considerable length of time, particularly for several months and especially without notice, it is assumed that the remaining team members will take up your responsibilities and make necessary decisions (possibly without waiting for your return if a quick decision is required).
https://review.coreboot.org/c/flashrom/+/76075/comment/4ac0b989_d9e869ef : PS3, Line 44: Merge all contributors's patches (when they are ready), not just your own. Merge all contributors' patches when they're ready, not just their own.
https://review.coreboot.org/c/flashrom/+/76075/comment/00887a59_bb400483 : PS3, Line 44: * Members of this group are expected to:
https://review.coreboot.org/c/flashrom/+/76075/comment/7b07270e_a89ba87d : PS3, Line 46: Be at least vaguely aware what development efforts are ongoing, this helps to make decisions : in what order the patches should be merged, and where could be merge conflicts. Maintain a basic awareness of ongoing development efforts to aid decision-making regarding the sequence of patch merging and possible merge conflicts.
https://review.coreboot.org/c/flashrom/+/76075/comment/0d13c190_c52dea4e : PS3, Line 49: Know development guidelines, and educate other contributors if needed (e.g. give links). Understand the development guidelines and guide other contributors if necessary, for example by providing relevant links.
https://review.coreboot.org/c/flashrom/+/76075/comment/962e9577_c0b206b1 : PS3, Line 51: * React to patches when added as a reviewer. Engage with patches when marked as a reviewer.
https://review.coreboot.org/c/flashrom/+/76075/comment/d3c27f0c_d52d28cc : PS3, Line 53: * Try to respond to technical questions on the mailing list if the topic is something you know about : and can provide a useful response. : Attempt to respond to technical inquiries on the mailing list if the topic falls within your knowledge and you can provide a helpful response.
https://review.coreboot.org/c/flashrom/+/76075/comment/932f4753_e95c8196 : PS3, Line 56: * From time to time show up in real-time channel(s) and/or dev meetings. Occasionally participate in real-time channels and/or developer meetings.
https://review.coreboot.org/c/flashrom/+/76075/comment/033bdbf4_5205aced : PS3, Line 58: * Follow the Code of Conduct and Friendliness guidelines, be a good example for others. : : Adhere to the Code of Conduct and Friendliness guidelines, setting a positive example for others.
https://review.coreboot.org/c/flashrom/+/76075/comment/39edaadb_ffe5fe73 : PS3, Line 60: * Bonus point: if you work in a [software] company, educate and help contributors from your company : with upstream culture and dev guidelines. : Bonus: If you're employed at a company that uses flashrom, please try to guide and educate your company's contributors about the upstream culture and development guidelines.
-
Stefan Reinauer (Code Review)