Attention is currently required from: Felix Singer, Edward O'Callaghan, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 )
Change subject: meson: use static library for tests
......................................................................
Patch Set 2:
(2 comments)
File tests/flashrom.c:
https://review.coreboot.org/c/flashrom/+/64031/comment/f6fd781f_9da2a719
PS1, Line 14: */
Re-add linebreak
Done
File tests/meson.build:
https://review.coreboot.org/c/flashrom/+/64031/comment/8b327b17_bd1faeea
PS1, Line 93: files(
: 'io_mock.c',
: 'tests.c',
: 'libusb_wraps.c',
: 'helpers.c',
: 'flashrom.c',
: 'spi25.c',
: 'lifecycle.c',
: 'layout.c',
: 'chip.c',
: ),
I feel like the src array should be separated out from the control block.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64031
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd
Gerrit-Change-Number: 64031
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 06 May 2022 21:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment