Change in flashrom[master]: Makefile: use HAS_ USE_ pattern for serial support - flashrom-gerrit

11 Mar 2022


      Attention is currently required from: Felix Singer, Nico Huber.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62196 )
Change subject: Makefile: use HAS_ USE_ pattern for serial support
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: 
I've build tested it on Linux and openindiana (SunOS successor)
openindiana builds successful with `gmake WARNERROR=no` and has all serial programmer enabled.
WARNERROR=no is needed for other bugs.
File Makefile:
https://review.coreboot.org/c/flashrom/+/62196/comment/c124a5ed_1ba39d3d 
PS2, Line 807: ifneq ($(NEED_POSIX_SOCKETS), )
...
Yes, it's only serprog. I'll make an extra group.
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62196
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ica951e76d6362b01f09d23a729a2a6049e7f0b66
Gerrit-Change-Number: 62196
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Fri, 11 Mar 2022 22:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Gerrit-MessageType: comment