Nico Huber has posted comments on this change. ( https://review.coreboot.org/20224 )
Change subject: serial: Support custom baud rates on linux ......................................................................
Patch Set 3:
(3 comments)
Looks good :)
https://review.coreboot.org/#/c/20224/3/custom_baud.h File custom_baud.h:
https://review.coreboot.org/#/c/20224/3/custom_baud.h@31 PS3, Line 31: /* Returns 1 if non-exact rate would be used, and setting a custom rate is supported. */ Maybe mention that baudtable has to be ordered ascendingly.
https://review.coreboot.org/#/c/20224/3/custom_baud.c File custom_baud.c:
https://review.coreboot.org/#/c/20224/3/custom_baud.c@51 PS3, Line 51: * Could you push the asterisk one char to the right?
https://review.coreboot.org/#/c/20224/3/custom_baud.c@74 PS3, Line 74: * here too
-
Nico Huber (Code Review)