Change in flashrom[master]: flashchips: Add Macronix MX25U8032E - flashrom-gerrit

7 Oct 2018


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/28821 )
Change subject: flashchips: Add Macronix MX25U8032E
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/28821/1/flashchips.c
File flashchips.c:
https://review.coreboot.org/#/c/28821/1/flashchips.c@8449
PS1, Line 8449: 				.block_erase = spi_block_erase_d8,
...
I don't see that in the datasheet...
Gone
https://review.coreboot.org/#/c/28821/1/flashchips.c@8450
PS1, Line 8450:
...
should probably be removed too
Gone
-- 
To view, visit https://review.coreboot.org/28821
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I422c3d51e5011e081ff6bccff294817c8c1765d0
Gerrit-Change-Number: 28821
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Oct 2018 11:06:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No