Attention is currently required from: Felix Singer, Angel Pons.
Liam Flaherty has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69713 )
Change subject: flashchips.c: Add 4BA write to XM25Qx256C
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69713/comment/0038e93c_307f9f3d
PS2, Line 10: command (0x12) according to their datasheets, but the feature flag is not enabled in flashchips.c, so enable it to allow this feature to be used.
Wrap at 72 chars
Done
https://review.coreboot.org/c/flashrom/+/69713/comment/3e1d52c5_d2df714e
PS2, Line 11:
Tested?
I don't have access to these chips, so I have left the `tested` field as `TEST_UNTESTED`. This change is based on what the datasheet claims.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I96c80762fcda2af6028c7a53d8c545b0c6565cbd
Gerrit-Change-Number: 69713
Gerrit-PatchSet: 3
Gerrit-Owner: Liam Flaherty
liamflaherty@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 18 Nov 2022 00:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment