Change in flashrom[master]: usb_device: Fix memory leak

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40651 )

Change subject: usb_device: Fix memory leak
......................................................................

usb_device: Fix memory leak

Change-Id: I19c91ae881895ecc4ea85dcfd40a69bb58289a60
Found-by: Coverity Scan #1420203
Signed-off-by: Patrick Georgi 
---
M usb_device.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/51/40651/1

diff --git a/usb_device.c b/usb_device.c
index 48833fb..344c4cb 100644
--- a/usb_device.c
+++ b/usb_device.c
@@ -226,6 +226,8 @@
    						  &descriptor));
    	      if (ret != 0) {
    		      msg_perr("USB: Failed to get device descriptor");
+			      free(*devices);
+			      *devices = NULL;
    		      return ret;
    	      }

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40651 )

Change subject: usb_device: Fix memory leak
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40651 )

Change subject: usb_device: Fix memory leak
......................................................................

Patch Set 1: Code-Review+2

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40651 )

Change subject: usb_device: Fix memory leak
......................................................................

Patch Set 1: Code-Review+2

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40651 )

Change subject: usb_device: Fix memory leak
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/40651 )

Change subject: usb_device: Fix memory leak
......................................................................

usb_device: Fix memory leak

Change-Id: I19c91ae881895ecc4ea85dcfd40a69bb58289a60
Found-by: Coverity Scan #1420203
Signed-off-by: Patrick Georgi 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/40651
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
Reviewed-by: Stefan Reinauer 
Reviewed-by: Edward O'Callaghan 
---
M usb_device.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Stefan Reinauer: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved
  Edward O'Callaghan: Looks good to me, approved

diff --git a/usb_device.c b/usb_device.c
index 48833fb..344c4cb 100644
--- a/usb_device.c
+++ b/usb_device.c
@@ -226,6 +226,8 @@
    						  &descriptor));
    	      if (ret != 0) {
    		      msg_perr("USB: Failed to get device descriptor");
+			      free(*devices);
+			      *devices = NULL;
    		      return ret;
    	      }