Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Andrew Bresticker.
johnsonh@waymo.com has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56164 )
Change subject: ft2232_spi: Add FTDI search by description.
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56164/comment/5b388d9a_f3b77c3e
PS4, Line 17: with the same vid/pid/serial number are plugged in, description can still
Looks like this line is just one char over the limit (72 chars). […]
Done
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/56164/comment/3aff8c9f_5fbd3dee
PS4, Line 504: f = ftdi_usb_open_desc(&ftdic, ft2232_vid, ft2232_type, arg2, arg)
Just to double-check, basic case when there is only one device and description param is not provided […]
Done, and added a note to the commit description.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56164
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib4be23247995710900175f5f16e38db577ef08fa
Gerrit-Change-Number: 56164
Gerrit-PatchSet: 5
Gerrit-Owner: johnsonh@waymo.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrew Bresticker
abrestic@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Andrew Bresticker
abrestic@google.com
Gerrit-Comment-Date: Mon, 26 Jul 2021 18:55:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment