David Hendricks has posted comments on this change. ( https://review.coreboot.org/25133 )
Change subject: Enable 4BA mode for Spansion 25FL256S
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
same comment as the previous patch w.r.t. comment style
https://review.coreboot.org/#/c/25133/6/flash.h
File flash.h:
https://review.coreboot.org/#/c/25133/6/flash.h@120
PS6, Line 120: *<
Hmmm, I can't remember when or why we started doing this with comments.
--
To view, visit
https://review.coreboot.org/25133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I807bf55d65763a9f48a6a3377f14f4e5288a7a4c
Gerrit-Change-Number: 25133
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 03 Oct 2018 12:43:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes