Attention is currently required from: Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70006 )
Change subject: layout: Check return values for strdup in register_include_arg ......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/70006/comment/6c8c0790_e9df4daa PS5, Line 9: strdup return values should be checked for NULL to catch the : potential error case of out of memory.
It looks much better. […]
I have made something! CB:70539 Thank you for your help!
File layout.c:
https://review.coreboot.org/c/flashrom/+/70006/comment/3e144692_4382159a PS7, Line 123: char *file = NULL; /* file is optional, so defaults to NULL */
(consider this comment to be a non-blocking nit since the code is fine as you've written it and Edwa […]
Oh thank you for sharing ideas! I did next patch (on the top of this one) to implement Edward's suggestion. But maybe your idea can be one more next step in refactoring? If I do it, I would do one more separate patch.