Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62891 )
Change subject: ichspi: Introduce FCYCLE_MASK(n) macro ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62891/comment/a388f925_07d30b2e PS3, Line 12: Also, drops unused macros (PCH100_HSFC_FCYCLE_OFF and : PCH100_HSFC_FCYCLE).
Ack
I am slightly confused, you said Ack but haven't changed anything? If there is a reason why these two things need to be in the same patch, that fine, but you can just reply and explain why, so that everyone understands why things are done in this way.
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62891/comment/deffce12_1bc58dbb PS3, Line 80: /* Changed HSFC Control bits */
Ack
I am slightly confused, there were two comments in a row, and you removed not the one I was asking about, is that intentional?
It was /* Changed HSFC Control bits */ <-- I thought this can be removed with the code? <patch removes two lines from here> /* New HSFC Control bit */ <-- But you removed this one instead?
-
Anastasia Klimchuk (Code Review)