Attention is currently required from: Nico Huber. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52596 )
Change subject: mec1308.c: Untangle successful vs failed init paths ......................................................................
Patch Set 3:
(1 comment)
File mec1308.c:
https://review.coreboot.org/c/flashrom/+/52596/comment/fab96e82_c35fa8c8 PS1, Line 519: mec1308_init_exit
I would probably rename it, e.g. `mec1308_init_err`. It's not "the" exit anymore. […]
Yeah I was thinking about those label names a lot, I agree just saying this one is "exit" is not ideal. Especially since this patch aims to "Untangle successful vs failed init paths", I feel it's relevant here to get the right name. So my second attempt is "init_err_exit" here (and "init_err_cleanup_exit" in 52597).
-
Anastasia Klimchuk (Code Review)