Change in flashrom[master]: hwaccess_x86_msr: rename msr function to msr_xxx - flashrom-gerrit

12 Apr 2022


      Attention is currently required from: Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62851 )
Change subject: hwaccess_x86_msr: rename msr function to msr_xxx
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62851/comment/98eba5e1_dcba55f3 
PS3, Line 10: na
understan*d*able
File hwaccess_x86_msr.c:
https://review.coreboot.org/c/flashrom/+/62851/comment/cc0934e8_011cd73f 
PS4, Line 302:  * DirectHW has identical, but conflicting typedef for msr_t. We redefine msr_t
If it's identical, couldn't we just cast from one type to the other?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie5ad54d198312578e0a1ee719eec67b37d2bf6a4
Gerrit-Change-Number: 62851
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 12 Apr 2022 08:44:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment