Attention is currently required from: Subrata Banik, Angel Pons, Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62891 )
Change subject: ichspi: Introduce FCYCLE_MASK(n) macro ......................................................................
Patch Set 7:
(3 comments)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62891/comment/3998961f_9b166be6 PS6, Line 88: Changed HSFC Control bits These are register fields that changed with Sunrise Point, please keep things grouped by the comments.
https://review.coreboot.org/c/flashrom/+/62891/comment/99104afd_66b8ff43 PS6, Line 147: 4K Not always 4K.
https://review.coreboot.org/c/flashrom/+/62891/comment/8d884e60_181b1c40 PS6, Line 150: /* : * 4 bits to represents the FCYCLE operation for PCH as: : * 0: SPI Read : * 2: SPI Write : * 3: SPI Erase 4K : * 4: SPI Erase 64K : * 6: SPI RDID : * 7: SPI Write Status : * 8: SPI Read Status : */ : #define HSFC_FCYCLE_BIT_WIDTH_PCH 0xf Please don't mix ICH9 with PCH100 definitions.