Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60846 )
Change subject: nicintel_spi: remove unused rget_io_perms() ......................................................................
nicintel_spi: remove unused rget_io_perms()
The nicintel_spi programmer does not use x86 IO Ports. Remove the dependency to it.
Change-Id: I3e7451eceb1f01de21da934c9559dbf2f06e7e54 Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/60846 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile M nicintel_spi.c 2 files changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Makefile b/Makefile index 93fc657..34d517e 100644 --- a/Makefile +++ b/Makefile @@ -128,7 +128,6 @@ CONFIG_ATAPROMISE \ CONFIG_INTERNAL \ CONFIG_NIC3COM \ - CONFIG_NICINTEL_SPI \ CONFIG_NICNATSEMI \ CONFIG_NICREALTEK \ CONFIG_OGP_SPI \ diff --git a/nicintel_spi.c b/nicintel_spi.c index 852c042..004af66 100644 --- a/nicintel_spi.c +++ b/nicintel_spi.c @@ -35,7 +35,6 @@ #include "flash.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h"
@@ -293,9 +292,6 @@ { struct pci_dev *dev = NULL;
- if (rget_io_perms()) - return 1; - dev = pcidev_init(nics_intel_spi, PCI_BASE_ADDRESS_0); if (!dev) return 1;