Nico Huber has posted comments on this change. ( https://review.coreboot.org/17945 )
Change subject: Add functions to read/erase/write/verify by layout ......................................................................
Patch Set 6:
(3 comments)
I think I'm done here :)
https://review.coreboot.org/#/c/17945/4/flashrom.c File flashrom.c:
PS4, Line 1764: size_t
int to match num_entries?
I've adapted `num_entries` instead. I'm not a fan of signed integers for index variables and got used to `size_t` (albeit I know that it's technically wrong, not a size; but that's how many people use it, even some POSIX functions).
Line 1855:
nit: add a newline above to separate the declarations and the body
Done
PS4, Line 1886: info->erase_start; /* within th
Thanks for updating the offset calculation. However, it somehow didn't end
Done