Change in flashrom[master]: Makefile: Remove 'NEED_LIBUSB1' from lspcon requiremnts

List overview All Threads
Download

newer

older

Change in flashrom[master]:...

Edward O'Callaghan (Code Review)

4 May 2020 4 May '20

1:34 a.m.

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/41020 )

Change subject: Makefile: Remove 'NEED_LIBUSB1' from lspcon requiremnts ......................................................................

Makefile: Remove 'NEED_LIBUSB1' from lspcon requiremnts

Since lspcon talks over i2c I doubt libusb is a build requiremnt, remove it.

Change-Id: Ic4d71c10d2d8c0c881aa5732daed35c20d905a5e Signed-off-by: Edward O'Callaghan quasisec@google.com --- M Makefile 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/41020/1

diff --git a/Makefile b/Makefile index 31e987c..803529f 100644 --- a/Makefile +++ b/Makefile @@ -955,7 +955,6 @@ ifeq ($(CONFIG_LSPCON_I2C_SPI), yes) FEATURE_CFLAGS += -D'CONFIG_LSPCON_I2C_SPI=1' PROGRAMMER_OBJS += lspcon_i2c_spi.o -NEED_LIBUSB1 += CONFIG_LSPCON_I2C_SPI endif

ifeq ($(CONFIG_REALTEK_MST_I2C_SPI), yes)

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Sam McNally (Code Review)

4 May 4 May

1:51 a.m.

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41020 )

Change subject: Makefile: Remove 'NEED_LIBUSB1' from lspcon requiremnts ......................................................................

Patch Set 1: Code-Review+2

(2 comments)

https://review.coreboot.org/c/flashrom/+/41020/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/41020/1//COMMIT_MSG@7 PS1, Line 7: requiremnts requirements

https://review.coreboot.org/c/flashrom/+/41020/1//COMMIT_MSG@10 PS1, Line 10: requiremnt requirement

-- To view, visit https://review.coreboot.org/c/flashrom/+/41020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4d71c10d2d8c0c881aa5732daed35c20d905a5e Gerrit-Change-Number: 41020 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 May 2020 01:51:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

2:23 a.m.

New subject: Change in flashrom[master]: Makefile: Remove 'NEED_LIBUSB1' from lspcon requirements

Hello Sam McNally, build bot (Jenkins), Shiyu Sun, Edward Hill,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/41020

to look at the new patch set (#2).

Change subject: Makefile: Remove 'NEED_LIBUSB1' from lspcon requirements ......................................................................

Makefile: Remove 'NEED_LIBUSB1' from lspcon requirements

Since lspcon talks over i2c I doubt libusb is a build requirement, remove it.

Change-Id: Ic4d71c10d2d8c0c881aa5732daed35c20d905a5e Signed-off-by: Edward O'Callaghan quasisec@google.com --- M Makefile 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/20/41020/2

-- To view, visit https://review.coreboot.org/c/flashrom/+/41020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4d71c10d2d8c0c881aa5732daed35c20d905a5e Gerrit-Change-Number: 41020 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Edward O'Callaghan (Code Review)

2:23 a.m.

New subject: Change in flashrom[master]: Makefile: Remove 'NEED_LIBUSB1' from lspcon requirements

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41020 )

Change subject: Makefile: Remove 'NEED_LIBUSB1' from lspcon requirements ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/flashrom/+/41020/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/41020/1//COMMIT_MSG@7 PS1, Line 7: requiremnts

...

requirements

Done

https://review.coreboot.org/c/flashrom/+/41020/1//COMMIT_MSG@10 PS1, Line 10: requiremnt

...

requirement

Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/41020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4d71c10d2d8c0c881aa5732daed35c20d905a5e Gerrit-Change-Number: 41020 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 04 May 2020 02:23:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally sammc@google.com Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

5:26 a.m.

New subject: Change in flashrom[master]: Makefile: Remove 'NEED_LIBUSB1' from lspcon requirements

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/41020 )

Change subject: Makefile: Remove 'NEED_LIBUSB1' from lspcon requirements ......................................................................

Makefile: Remove 'NEED_LIBUSB1' from lspcon requirements

Since lspcon talks over i2c I doubt libusb is a build requirement, remove it.

Change-Id: Ic4d71c10d2d8c0c881aa5732daed35c20d905a5e Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/41020 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sam McNally sammc@google.com --- M Makefile 1 file changed, 0 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved

ifeq ($(CONFIG_REALTEK_MST_I2C_SPI), yes)

-- To view, visit https://review.coreboot.org/c/flashrom/+/41020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic4d71c10d2d8c0c881aa5732daed35c20d905a5e Gerrit-Change-Number: 41020 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Sam McNally sammc@google.com Gerrit-Reviewer: Shiyu Sun sshiyu@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1693

days inactive

1693

days old

flashrom-gerrit@flashrom.org

4 comments

2 participants

tags (0)

participants (2)

Edward O'Callaghan (Code Review)
Sam McNally (Code Review)