[M] Change in flashrom[master]: writeprotect.c: differentiate lack of WP from lack of implementation - flashrom-gerrit

15 Jan 2023


      Attention is currently required from: Nico Huber, Nikolai Artemiev, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68221 )
Change subject: writeprotect.c: differentiate lack of WP from lack of implementation
......................................................................
Patch Set 7:
(2 comments)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/68221/comment/b05c8681_2b73ded6 
PS7, Line 425: verify_chip_support
`chip_supported()` makes more sense imho.
https://review.coreboot.org/c/flashrom/+/68221/comment/88885bfc_8b8d2929 
PS7, Line 427: flash->chip == NULL
`!ptr` is canonical.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/68221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6e75b124c21ccab51a9b5e1cd344b5310d384187
Gerrit-Change-Number: 68221
Gerrit-PatchSet: 7
Gerrit-Owner: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Sun, 15 Jan 2023 01:30:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment