Attention is currently required from: Hsuan Ting Chen.
Kapil Porwal has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email )
Change subject: flashchips.c: Add reg_bits for W25Q256JW
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/85323/comment/39e482e8_c88e69b0?usp... :
PS1, Line 11:
Please add the link-to datasheet, e.g. https://www.winbond.com/hq/support/documentation/levelOne. […]
Acknowledged
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/85323/comment/79136ab9_333ae7e8?usp... :
PS1, Line 20341: TEST_OK_PREWB
I see this is marked as tested. […]
Acknowledged. Updated the commit message with test details.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/85323?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e
Gerrit-Change-Number: 85323
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Comment-Date: Wed, 27 Nov 2024 09:13:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com