[S] Change in flashrom[master]: tests/lifecycle.c: Avoid unnecessary heap allocations - flashrom-gerrit

17 Jan 2023


      Attention is currently required from: Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71918 )
Change subject: tests/lifecycle.c: Avoid unnecessary heap allocations
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/71918/comment/f95761b8_c685a948 
PS2, Line 85: char *param_dup = strdup(param);
oh this did not have check for NULL... you fixed a bug :)
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/71918
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0414ab9a63867fc58b04ad62ed3ec4f221448a58
Gerrit-Change-Number: 71918
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Wed, 18 Jan 2023 00:37:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment