Attention is currently required from: Nico Huber, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55714 )
Change subject: acpi_ec: Implement basic ACPI embedded controller API ......................................................................
Patch Set 6:
(6 comments)
File acpi_ec.h:
https://review.coreboot.org/c/flashrom/+/55714/comment/7f28dc10_ab972d89 PS4, Line 8: * the Free Software Foundation; version 2 of the License.
It would be nice if you could convince TUXEDO to put it under GPLv2+. […]
Done
https://review.coreboot.org/c/flashrom/+/55714/comment/5500a922_54165807 PS4, Line 26: /* Standard ports */ : #define EC_DATA 0x62 : #define EC_CONTROL 0x66 /* Read status, write commands */ : : /* Standard commands */ : #define EC_CMD_READ_REG 0x80 /* Read register's value */ : #define EC_CMD_WRITE_REG 0x81 /* Write register's value */ : : /* Some of the status bits */ : #define EC_STS_IBF (1 << 1) /* EC's input buffer full (host can't write) */ : #define EC_STS_OBF (1 << 0) /* EC's output buffer full (host can read) */ :
Do these need to be exported?
Done
https://review.coreboot.org/c/flashrom/+/55714/comment/3f9972d5_093ec352 PS4, Line 41: bool ec_wait_for_ibuf(uint8_t control_port, unsigned int max_checks); : bool ec_wait_for_obuf(uint8_t control_port, unsigned int max_checks);
Actually they don't
Done
https://review.coreboot.org/c/flashrom/+/55714/comment/0baa6b3a_964665e1 PS4, Line 44: bool ec_write_cmd(uint8_t control_port, uint8_t cmd, unsigned int max_checks); : bool ec_read_byte(uint8_t control_port, uint8_t data_port, uint8_t *data, : unsigned int max_checks); : bool ec_write_byte(uint8_t control_port, uint8_t data_port, uint8_t data, : unsigned int max_checks); :
see this comment on why the ports are switched https://review.coreboot. […]
Now the ports are fixed to standard 62/66, no more parameters for the port
File acpi_ec.c:
https://review.coreboot.org/c/flashrom/+/55714/comment/a6b213d2_b8b94986 PS4, Line 23: ontrol_port
See EC ACPI spec […]
Fixed the register names
https://review.coreboot.org/c/flashrom/+/55714/comment/b96527de_43cb88a1 PS4, Line 95: EC_CMD_READ_REG
EC_CMD_WRITE_REG?
Yes... Done
-
Michał Żygowski (Code Review)