Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/39972 )
Change subject: cli_classic.c: Prevent memory leak ......................................................................
cli_classic.c: Prevent memory leak
If the `--flash-contents` switch is specified more than once, it will result in a memory leak. Therefore, allow this option only once.
Change-Id: I530933c9a6431580fe4645396bb363939472a80a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M cli_classic.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/39972/1
diff --git a/cli_classic.c b/cli_classic.c index 73cc417..967ff50 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -273,6 +273,9 @@ } break; case OPTION_FLASH_CONTENTS: + if (referencefile) + cli_classic_abort_usage("Error: --flash-contents specified more than once." + "Aborting.\n"); referencefile = strdup(optarg); break; case OPTION_FLASH_NAME:
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39972 )
Change subject: cli_classic.c: Prevent memory leak ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/39972 )
Change subject: cli_classic.c: Prevent memory leak ......................................................................
cli_classic.c: Prevent memory leak
If the `--flash-contents` switch is specified more than once, it will result in a memory leak. Therefore, allow this option only once.
Change-Id: I530933c9a6431580fe4645396bb363939472a80a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/39972 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M cli_classic.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/cli_classic.c b/cli_classic.c index 73cc417..967ff50 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -273,6 +273,9 @@ } break; case OPTION_FLASH_CONTENTS: + if (referencefile) + cli_classic_abort_usage("Error: --flash-contents specified more than once." + "Aborting.\n"); referencefile = strdup(optarg); break; case OPTION_FLASH_NAME:
-
Angel Pons (Code Review) -
Nico Huber (Code Review)