Change in flashrom[master]: flashchips: Add Spansion 25FL256S......0 - flashrom-gerrit

3 Oct 2018


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/25132 )
Change subject: flashchips: Add Spansion 25FL256S......0
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Code looks good. There was a comment with some superfluous characters which you may fix at your discretion before submitting.
https://review.coreboot.org/#/c/25132/5/flash.h
File flash.h:
https://review.coreboot.org/#/c/25132/5/flash.h@237
PS5, Line 237: *<
No need for the *<
-- 
To view, visit https://review.coreboot.org/25132
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a95a81dfe86434f049215ebd8477392391b9efc
Gerrit-Change-Number: 25132
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 03 Oct 2018 12:37:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes