Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73495 )
Change subject: linux_mtd.c: Factor out detection phases from setup func
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Can you split this chain in independent ones? It is quite hard to keep track of every change in it.
+1, maybe add a patch that moves linux_mtd_setup to its current location, then apply this patch on top, that should be easier to follow
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73495
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15915b71e1a030548c5f082cde78c42ece28bb37
Gerrit-Change-Number: 73495
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Wed, 19 Apr 2023 06:45:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment