Change in flashrom[master]: pony_spi.c: Fix memory leak in function pony_init_spi - flashrom-gerrit

10 Mar 2022


      Attention is currently required from: Light.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 )
Change subject: pony_spi.c: Fix memory leak in function pony_init_spi
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
...
Thanks for pointing out the mistakes. I have made the changes accordingly. […]
Hi, it's what I described here: https://review.coreboot.org/c/flashrom/+/62724/1..3/pony_spi.c#b167
In a nutshell, `register_shutdown(pony_spi_shutdown, data)` registers the shutdown function *and also* stores a copy of the pointer to the data to be freed. I didn't explicitly mention this second part in my other comment.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62724
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301
Gerrit-Change-Number: 62724
Gerrit-PatchSet: 3
Gerrit-Owner: Light aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Light aarya.chaumal@gmail.com
Gerrit-Comment-Date: Thu, 10 Mar 2022 15:17:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Light aarya.chaumal@gmail.com
Gerrit-MessageType: comment