Brian Norris has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82083?usp=email )
Change subject: flashrom_tester: Correct "WP screw" message
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS5:
How about this patch goes ahead and then later we can update the message? […]
I was out last week, FYI. Thanks for the review + submission.
I don't really have any opinion on most of the questions. I just wanted to fix the incorrect message, and so I made the least intrusive change to make it correct. If you want to upgrade the checks here or improve the wording, be my guest :)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82083?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270
Gerrit-Change-Number: 82083
Gerrit-PatchSet: 6
Gerrit-Owner: Brian Norris
briannorris@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evan Benn
evanbenn@gmail.com
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 May 2024 19:43:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment