Change in flashrom[master]: hwaccess.c: Fix PowerPC memory barrier - flashrom-gerrit

9 Jul 2021


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Arthur Heymans.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52470 )
Change subject: hwaccess.c: Fix PowerPC memory barrier
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
...
This change can wait for now.
What part of this is hard to predict? Isn't this fixing a compilation error (specifically guarded with IS_PPC) and doing so in full accordance with what's done on SPARC as well?
File hwaccess.c:
https://review.coreboot.org/c/flashrom/+/52470/comment/ddba8668_a1dd4b22 
PS4, Line 74: __asm__ __volatile__
why is __asm__ __volatile__ used on PPC but asm volatile is used below on SPARC?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia84fd1362a1d39aca6269eef22ac994dee68ba4b
Gerrit-Change-Number: 52470
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 09 Jul 2021 02:56:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment