Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58484 )
Change subject: libflashrom,writeprotect: add flashrom_wp_{config,range,mode}_to_str() ......................................................................
Patch Set 11:
(2 comments)
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58484/comment/23d74627_935ca34c PS11, Line 138: #define FLASHROM_WP_OUT_STR_SIZE 1024 Why 1024? Same question for 128 above. An arbitrary number is totally fine, but a comment would be helpful, even if the comment like programmer.c#112 it is still helpful, gives information.
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58484/comment/ebad3c5b_0dd3537c PS11, Line 436: for (int i = cfg->srp_bit_count - 1; i >= 0; i--) { : buf += sprintf(buf, "SRP%d=%u ", i, cfg->srp[i]); : } : : if (cfg->cmp_bit_present) : buf += sprintf(buf, "CMP=%u ", cfg->cmp); : : if (cfg->sec_bit_present) : buf += sprintf(buf, "SEC=%u ", cfg->sec); : : if (cfg->tb_bit_present) : buf += sprintf(buf, "TB=%u ", cfg->tb); : : for (int i = cfg->bp_bit_count - 1; i >= 0; i--) { : buf += sprintf(buf, "BP%d=%u ", i, cfg->bp[i]); : } : I would prefer the same ordering as in wp_chip_struct defined in CB:58478