[M] Change in flashrom[master]: drivers: Move (un)map_flash_region to par/spi/opaque_master
Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Jonathon Hall, Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region to par/spi/opaque_master ......................................................................
Patch Set 8:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/36e2ecb4_a70012ef PS2, Line 1865: &mapper_phys
Yep thank you all, I totally agree! I'm still getting the hang of the Gerrit workflow and what works best for review but I really appreciate all the help!
It is our duty to introduce newcomers to the Gerrit workflows and mechanics, as we all were newcomers at some point. And given that we're going to run into each other rather frequently, we might as well work towards making the review process as pleasant as possible for everyone involved.
I will rebase this on those patches and split it up. I think this will require temporarily adding a mapper to the opaque bus master that I then remove in a later patch, but that should be straightforward.
Sounds good. It can't be worse than that one temporary macro with 24 parameters that we devised to enable refactoring of RAM init code in a reviewable way. RAM init code is full of magic numbers, and extremely hard to test. By leveraging reproducible builds to adapt the code, most of the non-reproducible refactoring got reduced to CB:40980 which replaces the implementation without changing the magic numbers. 😄
-
Angel Pons (Code Review)