Attention is currently required from: Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61276 )
Change subject: hwaccess_x86_io: clean header concept
......................................................................
Patch Set 7: Code-Review+1
(3 comments)
Patchset:
PS7:
New code looks good, still need to compare it to the old code...
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61276/comment/e838271d_ae77207c
PS7, Line 36: * functions. `platform_get_io_perms()` is called to get
Please drop the trailing whitespace that Gerrit marks so keenly.
https://review.coreboot.org/c/flashrom/+/61276/comment/9a50d5ac_dc3ad27f
PS7, Line 352: a
ass*e*mbly
--
To view, visit
https://review.coreboot.org/c/flashrom/+/61276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1400704e9ac5fed00c096796536108d5bfb875e3
Gerrit-Change-Number: 61276
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 15 Feb 2022 13:47:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment