[M] Change in flashrom[master]: flashrom.c:Add function to get a flattened view of the chip erase blocks - flashrom-gerrit

12 Dec 2022


      Attention is currently required from: Nico Huber, Paul Menzel, Edward O'Callaghan, Aarya.
Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65879 )
Change subject: flashrom.c:Add function to get a flattened view of the chip erase blocks
......................................................................
Patch Set 42:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65879/comment/f3c68b70_e3fc56a1 
PS42, Line 1249: index
...
doesn't `index` and `i` count in tandem? You can just use `i` and drop the `index`?
I think `continue` makes `index` and `i` do not count in tandem.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/65879
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iafe78de00daa55f7114bd4ce09465dd88074ece4
Gerrit-Change-Number: 65879
Gerrit-PatchSet: 42
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Comment-Date: Mon, 12 Dec 2022 14:24:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment