Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine.
Piotr Halama has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 )
Change subject: flashchips: Add support for Boya BY25D80A
......................................................................
Patch Set 5:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/73513/comment/76b5b226_9a03eb34
PS2, Line 3552: {32 * 1024, 32}
Shouldn't it be `{16 * 1024. 64}`? I've updated `D8` to `{16 * 1024. […]
Ah, sorry, `{64 * 1024, 16}` does make more sense, updated
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7
Gerrit-Change-Number: 73513
Gerrit-PatchSet: 5
Gerrit-Owner: Piotr Halama
skrzynka@halamix2.pl
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Thu, 09 Mar 2023 20:48:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Piotr Halama
skrzynka@halamix2.pl
Gerrit-MessageType: comment