Attention is currently required from: Nico Huber, Paul Menzel, Peter Marheine. Hello build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/61194
to look at the new patch set (#5).
Change subject: hwaccess: fix build on non-x86 targets ......................................................................
hwaccess: fix build on non-x86 targets
The changes to hwaccess in commit 49d758698a0dd166679c48b1a2785e50e9b0cc83 cause build failure on non-x86 systems because the hwaccess_x86_* headers are included in some files that are built for all platforms (particularly those in the internal programmer) and those headers in turn include <sys/io.h> which only exists on x86.
This change makes the hwaccess_x86 headers a nop on non-x86 platforms so the internal programmer can be built without errors.
The comment on the stub implementation of rget_io_perms() is also modified to remove references to non-x86 platforms, since that file is only built on x86 now.
BUG=None TEST=meson build succeeds for both x86 and ARM targets
Signed-off-by: Peter Marheine pmarheine@chromium.org Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e --- M hwaccess_x86_io.c M hwaccess_x86_io.h M hwaccess_x86_msr.h M internal.c 4 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/61194/5