Attention is currently required from: Felix Singer, Angel Pons.
Name of user not set #1004656 has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69309 )
Change subject: Add support for XMC XM25QH128A. Read/write tested. ......................................................................
Patch Set 1:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69309/comment/92566da4_1bc179b6 PS1, Line 7: Add support for XMC XM25QH128A. Read/write tested.
flashchips: Add support for XMC XM25QH128A
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/bb1be76e_e6db2c50 PS1, Line 8:
Mention here what you have tested, a link to the datasheet and also information about the revision o […]
Has been read/write/erase tested. Is that sufficient and if not what other info should I provide?
I can link to Google cache of the datasheet on XMC's website, they took it offline recently. There's PDFs floating around as well but none hosted by the manufacturer anymore AFAICT.
Cheers
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/69309/comment/0b4935c6_2a329118 PS1, Line 19720: probe_spi_rdid
PROBE_SPI_RDID
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/54a9be8d_79608693 PS1, Line 19743: spi_chip_write_256
SPI_CHIP_WRITE256
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/13fc9934_dc2ac4e8 PS1, Line 19744: spi_chip_read
SPI_CHIP_READ
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/11f1d55b_8ef5a0ae PS1, Line 19755: decode_range_spi25
DECODE_RANGE_SPI25
Ack
https://review.coreboot.org/c/flashrom/+/69309/comment/7671d5a5_d9e8c9b1 PS1, Line 19758:
Remove one line
Ack
-
Name of user not set (Code Review)