[XS] Change in flashrom[main]: erasure_layout: Erase larger block only when all sub-block need erase

[Peter Marheine (Code Review)]

Attention is currently required from: Aarya, Anastasia Klimchuk, Bill XIE.

Peter Marheine has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84614?usp=email )

Change subject: erasure_layout: Erase larger block only when all sub-block need erase
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS1:
> Thank you for context! This was very educational, I understand now. […]

I think minimizing the number of bytes erased ("safe") is the correct default behavior, regardless. A command-line option to instead reduce the number of erases ("quick-n-dangerous", assumed to operate faster but wear flash faster) might be nice, though.

Making that a compile-time option seems like it's easy for a user to configure it to be quick-n-dangerous then unintentionally use that mode later, whereas requiring quick-n-dangerous mode to be opt-in for each invocation (default to safe operation) should prevent any surprises. The choice could also be easily exposed to library users then, too.