Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61275 )
Change subject: hwaccess_x86_io: refactor rget_io_perms() ......................................................................
Patch Set 7:
(3 comments)
File hwaccess_x86_io.c:
https://review.coreboot.org/c/flashrom/+/61275/comment/461e6567_7c136594 PS4, Line 124: msg_perr("Make sure you are root.\n");
If we change this already... There were some reports lately that the message […]
Done
https://review.coreboot.org/c/flashrom/+/61275/comment/62169873_92675f15 PS4, Line 126: "reboot, or reboot into single user mode.\n");
would be nice to keep the alignment, i.e. […]
Done
https://review.coreboot.org/c/flashrom/+/61275/comment/4dcb6f46_40f5f5a5 PS4, Line 128: "that your kernel configuration has the option INSECURE enabled.\n");
would be nice to keep the alignment, i.e. […]
Done
-
Thomas Heijligen (Code Review)