Change in flashrom[master]: pcidev.c: Simplify by consolidating common logic - flashrom-gerrit

27 Feb 2022


      Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59281 )
Change subject: pcidev.c: Simplify by consolidating common logic
......................................................................
Patch Set 2:
(1 comment)
File pcidev.c:
https://review.coreboot.org/c/flashrom/+/59281/comment/b523c625_908d10c3 
PS2, Line 175: pci_dev_find(vendor, 0)
...
isn't that current behavior? `struct pci_filter filter;` has a uninitialised member of `. […]
Looks like `pci_filter_init()` initialises the device ID to -1: https://github.com/pciutils/pciutils/blob/master/lib/filter.c#L23
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/59281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0048fc6ab816d230ff48c84bc17122431753d55d
Gerrit-Change-Number: 59281
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Sun, 27 Feb 2022 12:08:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment