Attention is currently required from: Aarya, Bill XIE.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84686?usp=email )
Change subject: erase/write: Deselect all smaller blocks when large block is selected ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Run the test scenario from CB:84614 and that's the result: double-erase seems gone
Reading old flash chip contents... read_flash: region (00000000..0xffffff) is readable, reading range (00000000..0xffffff). done. erase_write: region (00000000..0xffffff) is writable, erasing range (00000000..0xffffff). 000000..0xffffff verify_range: Verifying region (00000000..0xffffff) read_flash: region (00000000..0xffffff) is readable, reading range (00000000..0xffffff). E(0:ffffff)write_flash: region (00000000..0xffffff) is writable, writing range (00000000..0xffffff). W(0:ffffff)Erase/write done from 0 to ffffff Verifying flash... read_flash: region (00000000..0xffffff) is readable, reading range (00000000..0xffffff). VERIFIED. Writing chip.rom
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/84686/comment/127814fe_df505a33?usp... : PS1, Line 242: while (true) I want to re-write this as recursive fn `deselect_erase_functions`