Attention is currently required from: Nikolai Artemiev, Samantaz Fox, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Samantaz Fox. ( https://review.coreboot.org/c/flashrom/+/83970?usp=email )
Change subject: flashchips: Update test status for Fudan FM25Q08 and FM25Q128
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83970/comment/6db38900_f9aa7bf5?usp... :
PS1, Line 6243: { .probe = NT, .read = OK, .erase = OK, .write = OK },
Ah, for some reason I was convinced that flashrom would not probe when `-c name` was passed ^^
I even checked the code :) Yes it still probes when `-c` passed, but only for that one chip which is passed as an argument.
You can check, if you run command with `-VV` option (very verbose), it should print "Probing for " and then the name of chip.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83970?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ib3c94f03a132a912bb4bb9d36e8783f4468587c4
Gerrit-Change-Number: 83970
Gerrit-PatchSet: 2
Gerrit-Owner: Samantaz Fox
coding@samantaz.fr
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Samantaz Fox
coding@samantaz.fr
Gerrit-Comment-Date: Thu, 22 Aug 2024 09:45:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Samantaz Fox
coding@samantaz.fr