Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/52883
to look at the new patch set (#2).
Change subject: flashchips.c: merge GD25B128B/GD25Q128B and GD25Q127C/GD25Q128C ......................................................................
flashchips.c: merge GD25B128B/GD25Q128B and GD25Q127C/GD25Q128C
The 'B' and 'C' revisions have the same vendor ID / device ID and are mostly identical. Other than the names, the only difference between the definitions was that the 'C' definition had FEATURE_QPI enabled and the 'B' definition did not.
This difference appears to be a result of the 'B' definition predating the the FEATURE_QPI feature bit and the 'C' definition being added later. The 'B' chips also support QPI, so the merged definition has FEATURE_QPI enabled.
Merging the entries allows flashrom to automatically identify the chip without needing to be given the chip with the -C flag.
Chip revision history: - The 'GD25B128B/GD25Q128B' was originally added as 'GD25Q128' in `commit 1525b2ad16e07f035b1de70fadd05a7018ea5756` and later revised to 'GD25Q128B' and then 'GD25B128B/GD25Q128B'. - The 'GD25Q127C/GD25Q128C' definition was added in `commit e0c7abf219b81ad049d09a4671ebc9196153d308` as 'GD25Q128C' and later renamed to 'GD25Q127C/GD25Q128C'
BUG=b:153598437 BRANCH=none TEST=builds
Change-Id: I688f2e15aef61afbec728a9a81094bee56d6fbfa Signed-off-by: Nikolai Artemiev nartemiev@google.com --- M flashchips.c 1 file changed, 6 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/52883/2