[M] Change in flashrom[master]: tests: Add llvm-cov option and run target for code coverage - flashrom-gerrit

14 Nov 2022


      Attention is currently required from: Anastasia Klimchuk, Evan Benn.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69268 )
Change subject: tests: Add llvm-cov option and run target for code coverage
......................................................................
Patch Set 11:
(2 comments)
Patchset:
PS11: 
You should test if `llvm-cov-cli` can be found
https://mesonbuild.com/Reference-manual_functions.html#find_program
File meson.build:
https://review.coreboot.org/c/flashrom/+/69268/comment/2f94824e_7700446a 
PS11, Line 614:   run_target('llvm-cov-cli', command : ['scripts/llvm-cov', classic_cli])
This should also be guarded
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/69268
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id6c73bff46e7b88d425956a80def97082b201f56
Gerrit-Change-Number: 69268
Gerrit-PatchSet: 11
Gerrit-Owner: Evan Benn evanbenn@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Evan Benn evanbenn@google.com
Gerrit-Comment-Date: Mon, 14 Nov 2022 08:11:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment