Victor Ding has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/46812 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_LIBPCI ......................................................................
Mark ENE_LPC and MEC1308 as NEED_LIBPCI
Both depend on functions from chipset_enable.c and board_enable.c, which requires libpci; fixing.
Signed-off-by: Victor Ding victording@google.com Change-Id: I9505d7f18f4781a264e29e9667b717c061ba33b8 --- M Makefile 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/12/46812/1
diff --git a/Makefile b/Makefile index 3a0748c..241814a 100644 --- a/Makefile +++ b/Makefile @@ -823,8 +823,10 @@ override CONFIG_ATAHPT = no override CONFIG_ATAVIA = no override CONFIG_ATAPROMISE = no +override CONFIG_ENE_LPC = no override CONFIG_IT8212 = no override CONFIG_DRKAISER = no +override CONFIG_MEC1308 = no override CONFIG_NICREALTEK = no override CONFIG_NICNATSEMI = no override CONFIG_NICINTEL = no @@ -899,12 +901,14 @@ FEATURE_CFLAGS += -D'CONFIG_ENE_LPC=1' PROGRAMMER_OBJS += ene_lpc.o NEED_RAW_ACCESS += CONFIG_ENE_LPC +NEED_LIBPCI += CONFIG_ENE_LPC endif
ifeq ($(CONFIG_MEC1308), yes) FEATURE_CFLAGS += -D'CONFIG_MEC1308=1' PROGRAMMER_OBJS += mec1308.o NEED_RAW_ACCESS += CONFIG_MEC1308 +NEED_LIBPCI += CONFIG_MEC1308 endif
ifeq ($(CONFIG_SERPROG), yes)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46812 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_LIBPCI ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/flashrom/+/46812/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46812/1//COMMIT_MSG@10 PS1, Line 10: requires require
https://review.coreboot.org/c/flashrom/+/46812/1//COMMIT_MSG@10 PS1, Line 10: ; fixing drop `fixing`
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/46812
to look at the new patch set (#2).
Change subject: Mark ENE_LPC and MEC1308 as NEED_LIBPCI ......................................................................
Mark ENE_LPC and MEC1308 as NEED_LIBPCI
Both depend on functions from chipset_enable.c and board_enable.c, which require libpci.
Signed-off-by: Victor Ding victording@google.com Change-Id: I9505d7f18f4781a264e29e9667b717c061ba33b8 --- M Makefile 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/12/46812/2
Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46812 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_LIBPCI ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/46812/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46812/1//COMMIT_MSG@10 PS1, Line 10: requires
require
Done
https://review.coreboot.org/c/flashrom/+/46812/1//COMMIT_MSG@10 PS1, Line 10: ; fixing
drop `fixing`
Done
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46812 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_LIBPCI ......................................................................
Patch Set 2: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/46812 )
Change subject: Mark ENE_LPC and MEC1308 as NEED_LIBPCI ......................................................................
Mark ENE_LPC and MEC1308 as NEED_LIBPCI
Both depend on functions from chipset_enable.c and board_enable.c, which require libpci.
Signed-off-by: Victor Ding victording@google.com Change-Id: I9505d7f18f4781a264e29e9667b717c061ba33b8 Reviewed-on: https://review.coreboot.org/c/flashrom/+/46812 Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/Makefile b/Makefile index 3a0748c..241814a 100644 --- a/Makefile +++ b/Makefile @@ -823,8 +823,10 @@ override CONFIG_ATAHPT = no override CONFIG_ATAVIA = no override CONFIG_ATAPROMISE = no +override CONFIG_ENE_LPC = no override CONFIG_IT8212 = no override CONFIG_DRKAISER = no +override CONFIG_MEC1308 = no override CONFIG_NICREALTEK = no override CONFIG_NICNATSEMI = no override CONFIG_NICINTEL = no @@ -899,12 +901,14 @@ FEATURE_CFLAGS += -D'CONFIG_ENE_LPC=1' PROGRAMMER_OBJS += ene_lpc.o NEED_RAW_ACCESS += CONFIG_ENE_LPC +NEED_LIBPCI += CONFIG_ENE_LPC endif
ifeq ($(CONFIG_MEC1308), yes) FEATURE_CFLAGS += -D'CONFIG_MEC1308=1' PROGRAMMER_OBJS += mec1308.o NEED_RAW_ACCESS += CONFIG_MEC1308 +NEED_LIBPCI += CONFIG_MEC1308 endif
ifeq ($(CONFIG_SERPROG), yes)
-
Angel Pons (Code Review) -
Edward O'Callaghan (Code Review)
-
Victor Ding (Code Review)